-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: lmp-machine-custom: Use weaker assign for UBOOT_SIGN_ENABLE #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angolini
requested review from
ricardosalveti,
quaresmajose,
vanmaegima and
a team
September 4, 2023 13:57
reference: |
This was referenced Sep 4, 2023
vanmaegima
approved these changes
Sep 4, 2023
MrCry0
approved these changes
Sep 5, 2023
Please also extend the commit message to reflect the PR description used here. |
The goal is to provide an overridable default value to the UBOOT_SIGN_ENABLE variable. Using ??= to provide a default value for the imx generic bsp. This way, if a new machine is included in the platform, the default is defined by LmP. Using ? = to the reference machines, so it can be overrided by an .inc or a .conf file. To override the default value, use, for example: UBOOT_SIGN_ENABLE:sota:imx6ulevk = "0" Signed-off-by: Daiane Angolini <[email protected]>
@ricardosalveti done |
ricardosalveti
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to provide an overridable default value to the UBOOT_SIGN_ENABLE variable.
Using
??=
to provide a default value for the imx generic bsp. This way, if a new machine is included in the platform, the default is defined by LmP.Using
? =
to the reference machines, so it can be overrided by an.inc
or a.conf
file.To override the default value, use, for example: